nimble/host: move att_truncate_to_mtu to ble_att_svr_tx_rsp #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#AutoPTS run mynewt GATT/SR --test_case_limit 10 |
|
@rymanluk please review |
piotrnarajowski
force-pushed
the
truncate_mtu
branch
from
9f81db0
to
e123d39
Compare
piotrnarajowski
force-pushed
the
truncate_mtu
branch
from
e123d39
to
f79e5ff
Compare
rymanluk
approved these changes
Sep 25, 2024
piotrnarajowski
force-pushed
the
truncate_mtu
branch
from
f79e5ff
to
030cc74
Compare
|
@sjanc please approve workflow |
KKopyscinski
approved these changes
Sep 30, 2024
sjanc
requested changes
Sep 30, 2024
| conn = ble_hs_conn_find(conn_handle); | ||
| if (conn == NULL) { | ||
| hs_status = BLE_HS_ENOTCONN; | ||
| goto done; |
There was a problem hiding this comment.
this return with locked hs lock...
also I think ble_hs_conn_chan_find_by_scid() and ble_att_truncate_to_mtu() should also be under lock
Move att_truncate_to_mtu from ble_eatt_tx to ble_att_svr_tx_rsp. This could cause some issues when used by client.
piotrnarajowski
force-pushed
the
truncate_mtu
branch
from
030cc74
to
b83d3de
Compare
sjanc
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.